Support multiple pagers #4953
Support multiple pagers #4953
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
stefanhaller
force-pushed
the
multiple-pagers
branch
from
617b67c to
2e2bef9
Compare
This could have been removed in commit 9657b43.
This is an object that is owned by Gui, is accessible through GuiCommon.State(), and also passed down to GitCommand, where it is mostly needed. Right now it simply wraps access to the Git.Paging config, which isn't very exciting, but we'll extend it in the next commit to handle a slice of pagers (and maintain the currently selected pager index), and doing this refactoring up front allows us to make that change without having to touch clients.
stefanhaller
force-pushed
the
multiple-pagers
branch
from
2e2bef9 to
32bf6d6
Compare
|
FYI it took me like 30mn to figure out why pagers: as documented in the doc didn't work. It was because it's not released yet. |
I ran into this issue as well (and was confused for much longer :D). FYI in case it wasn't clear, pagers are supported (a single one), just needs to be added like https://github.com/jesseduffield/lazygit/blob/40e989467ffcb32e546eebca25b57972b6aac6b5/docs/Custom_Pagers.md. When the next version is released, your config will be automatically migrated into the I think a solution would be for the README links to point to the latest released commit's version of docs instead of master. |
|
The links from lazygit's status page already point to the docs of the current version you are running. But yes, for next time we'll have to think about adding "not released yet" markers, and removing them right before release. Quite a few people ran into this, and it also came up for other config changes in the past. |
|
IMO, it should be the exact same warning (e.g.: not released yet) so you can add the script for release (if you have one, otherwise in the instructions for the release) a sed command to remove the warning. |
|
@ilan-schemoul I think an even better approach is to not change the docs and the JSON schema at all for the lifetime of a release, and make those continuous changes to a copy instead; then, update the real docs from that copy right before making the next release. I made a PR that does this (#5010), and I'd appreciate reviews to see if there are any gaps in that approach. |
Allow configuring an array of pagers, and cycling through them with the
|key (mnemonic: we are piping the output through something). I find this useful for switching between delta (which I prefer most of the time) and difftastic (which occasionally produces better output for certain kinds of changes). It could also be used to switch between delta in inline mode and in side-by-side mode.